Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vSphere provider url help text field #751

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Oct 4, 2023

As a followup for #736, fix the vSphere provider's URL help text as follows:

  1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations.
  2. Set a url input ended with a "/" (i.e. "sdk/") as a valid url since it's a common used case.
  3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly).

As a followup for kubev2v#736, fix the vSphere provider's URL help text as follows:

1. Rephrase the error, warning and successful/initial text messages to be
   aligned with the documnetation, other providers fields and Patternfly error msg recommendations.
2. Set a url input ended with a "/" (i.e. "sdk/") as a valid url since it's a common used case.
3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed
   in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly).

Signed-off-by: Sharon Gratch <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sgratch sgratch requested a review from yaacov October 4, 2023 12:15
@yaacov yaacov merged commit ae21538 into kubev2v:release-v2.5.1 Oct 4, 2023
5 checks passed
@sgratch sgratch deleted the release-v2.5.1- branch October 4, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants